Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(attachment): convoy separation (#7449) #7451

Merged
merged 2 commits into from
Jun 28, 2024
Merged

fix(attachment): convoy separation (#7449) #7451

merged 2 commits into from
Jun 28, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Jun 27, 2024 •
edited
Loading

New

  • fix(attachment): convoy separation #7449
  • build: release v6.130.0 #7441

Tests

@kevin9foong
Regression on large submissions >10 crossing two convoys

  • Create 40 submissions with 20 attachments
  • Ensure that Download CSV (without attachment) returns 1 .csv file
  • Ensure that Download CSV with attachment returns 40 .zip and 1 .csv file

Regression on small submissions < 10

  • Create 7 submissions with 3 attachments only 1 convoy
  • Ensure that Download CSV (without attachment) returns 1 .csv file
  • Ensure that Download CSV with attachment returns 7 .zip and 1 .csv file

KenLSM added 2 commits June 27, 2024 21:43
@KenLSM
fix(attachment): convoy separation (#7449)
6a0823f 
* feat: add min separation time between each convoy

* fix: do not wait when waitTime is 0

* chore: fix typo

* fix: reduce convoy size to 5
@KenLSM
chore: bump version to v6.130.1
f1acaf0
@KenLSM KenLSM force-pushed the release-v6.130.1 branch from 4033e7e to f1acaf0 Compare June 27, 2024 13:47
@KenLSM KenLSM requested review from kevin9foong and g-tejas June 27, 2024 13:50
@kevin9foong
Copy link
Contributor

kevin9foong commented Jun 27, 2024 •
edited
Loading

lgtm and this is a really awesome fix!

ran the tests and verified that the # downloads is as expected.

@KenLSM KenLSM merged commit 9b98847 into release-al2 Jun 28, 2024
36 of 38 checks passed
@KenLSM KenLSM deleted the release-v6.130.1 branch June 28, 2024 02:21
@KenLSM KenLSM mentioned this pull request Jun 30, 2024
Merged
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin9foong kevin9foong kevin9foong approved these changes

@g-tejas g-tejas Awaiting requested review from g-tejas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KenLSM @kevin9foong